Re: [D7] Bug in TList.Sort

Hans-Peter Diettrich wrote:
> I wonder whether this bug has not been revealed before:
> 
> Before sorting a check of (Count > 0) is made, instead of > 1. An 
> attempt to sort a list with only 1 member will result in an Nil pointer 
> passed to the compare function, and BANG :-(
> 
> What about other (newer) Delphi versions?

I'm using Delphi 2008. While the compare function was (needlessly) 
called in this case, it got valid pointers passed to it. My test case 
was this:

function compare(item1,item2:pointer):integer;
begin
showmessage(inttostr(integer(item1))+','+inttostr(integer(item2)));
result:=integer(item2)-integer(item1);
end;

procedure TForm1.Button1Click(Sender: TObject);
var list:TList;
begin
  list:=TList.create;
  try
  list.add(pointer(1234));
  list.Sort(compare);
  finally
    list.free;
  end;
end;

The output is '1234,1234', '1234, 1234'.

Cheers,
Nicholas Sherlock
-----------------
www.Newsgroup-Binaries.com - *Completion*Retention*Speed*
Access your favorite newsgroups from home or on the road
-----------------