Re: Did I write a good (efficient) program?

"MikeB" <MPBrede@[EMAIL PROTECTED]
> wrote in message
news:5bc82b56-8468-4624-9602-4d7085ffe9ff@[EMAIL PROTECTED]
> Thank you. That was a valuable learning experience for me. I have 1
> simple question to see if I understood all of that code correctly.
>
>       * Compress adjacent "   0"s, once
>
>            move 1 to ip-compress-state
>            perform
>            varying ip-index1 from 1 by 4
>            until ip-index1 > 28
>                evaluate ip-compress-state
>                when 1
>                    if ip-octets (ip-index1:4) = "   0"
>                        and ip-octets (ip-index1 + 4:4) = "   0"
>                    then
>                        move spaces to ip-octets (ip-index1:4)
>                        move ":   " to ip-octets (ip-index1 + 4:4)
>                        move 2 to ip-compress-state
>                    else
>                        move 1 to ip-compress-state
>                    end-if
>                when 2
>
> The
>   else move 1 to ip-compress state seems redundant, since you
> can only ever be in that particular piece of code when the state = 1?
>
> I could not conceive of a logic path that would lead you to excecute
> that statement when the state would be other than 1, but perhaps I
> missed something?

It is redundant, but it shows what state will be the next
state. I do the same in the code following 'when 2', which
has 'move 2 to ip-compress-state', after adjusting for an
adjacent compressable field. Perhaps, it is something that
was left over from my days servicing computer equipment
that used ROM-based microprogramming, where next
address fields are never left empty.

> Once again, thank you. This is really great. And I learned a lot.

You're welcome, though I am left with the feeling that
I could have made it more clear as to how it worked or
perhaps had chosen a different way, if I had spent a bit
more time on it. And I apologize for not removing the
comment about formatting in reverse, which no longer
applies.