Re: realloc problem, corrupt last item

Igal wrote:
[...]
>         bp = (book*)realloc(bp, sizeof(book));

Here, you allocate room for one book.

I assume you really want:

          bp = realloc(bp, sizeof(*bp) * n);

which will allocate room for n books.

[...]
>         bp[n-1].cn = temp.cn;
>         bp[n-1].Units = temp.Units;
>         bp[n-1].Year = temp.Year;
>         bp[n-1].Price.CostPrice = temp.Price.CostPrice;
>         bp[n-1].Price.RetailPrice = temp.Price.RetailPrice;

Unless n==1, all of the above invoke UB by acessing memory
that does not belong to bp.

[...]

-- 
+-------------------------+--------------------+-----------------------+
| Kenneth J. Brody        | www.hvcomputer.com | #include              |
| kenbrody/at\spamcop.net | www.fptech.com     |    <std_disclaimer.h> |
+-------------------------+--------------------+-----------------------+
Don't e-mail me at: <mailto:ThisIsASpamTrap@[EMAIL PROTECTED]
>