Re: Wanna do a WriteLongwordBits contest ?

Skybuck Flying wrote:
> Your new version is better, but still has a serious shortcoming:
> 
> the DestBitIndex should be able to have any range.
> 
> Your method assumes parameter DestBitIndex has range 0 to 31, this is
too 
> restricted.

Huh?

The very first operation I do is to mask/update the base pointer and the 
bit index, specifically to handle index values above 31

> Your method writes garbage bits from the value as well...
> 
> Suppose the value is:
> 
> LSB ------------------------------> MSB
> |                                     |
> 1111 1111 1111 0000 0000 0000 0000 0000
> 
> Suppose the bit count is: 3


This is simply bogus, you should never try to write a value which would 
not fit inside the target field, or if you have to do so, then you 
should have a separate function which masks the input value before 
calling the base/fast function.

BTW, you even translated my normalization code to Pascal, and still 
didn't read it. You're amazing!

>  // Normalize bit index
>  longword(DestAddress) := longword(DestAddress) + (DestBitIndex shr 5);
>  DestBitIndex := DestBitIndex and 31;

Terje
-- 
- <Terje.Mathisen@[EMAIL PROTECTED]
>
"almost all programming can be viewed as an exercise in caching"